Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pods not being scheduled when ingress deployment is patched #5519

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix pods not being scheduled when ingress deployment is patched #5519

merged 1 commit into from
Oct 2, 2019

Conversation

woodcockjosh
Copy link
Contributor

This issue resolves #5518
Also update nginx-ingress-controller to 0.26.1 which resolves some other inconsistency issues

Fix pods not being scheduled when ingress deployment is patched
e468bf9 
Update nginx-ingress-controller to 0.26.1
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @woodcockjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: woodcockjosh
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woodcockjosh
Copy link
Contributor Author

/assign @sharifelgamal

@woodcockjosh
Copy link
Contributor Author

has same change as #5514

@medyagh
Copy link
Member

medyagh commented Oct 1, 2019

@minikube-bot Ok to test.

looks good ! thank you for improving minikube

@tstromberg tstromberg merged commit 41b9bcb into kubernetes:master Oct 2, 2019
@tstromberg
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees

@sharifelgamal sharifelgamal

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patching ingress deployment causes pods to never be scheduled
6 participants
@woodcockjosh @k8s-ci-robot @minikube-bot @medyagh @tstromberg @sharifelgamal